Skip to content

Comments

refactor dubbo-samples-merge#769

Merged
chickenlj merged 11 commits intoapache:masterfrom
dengWuuu:dev
Mar 6, 2023
Merged

refactor dubbo-samples-merge#769
chickenlj merged 11 commits intoapache:masterfrom
dengWuuu:dev

Conversation

@dengWuuu
Copy link
Contributor

@dengWuuu dengWuuu commented Mar 5, 2023

No description provided.

@chickenlj
Copy link
Contributor

@dengWuuu
Copy link
Contributor Author

dengWuuu commented Mar 6, 2023

Missing https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-echo/case-versions.conf

actually i have the case-versions.conf in my projext

@chickenlj
Copy link
Contributor

Missing https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-echo/case-versions.conf

actually i have the case-versions.conf in my projext

Yeah, please ignore it. I thought it was missing since it doesn't appear in the change list.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants