wip: listener add tls #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We suggest that you can add some examples about tls. |
|
我不确认该代码tls写法是否正确，如果正确的话，加密后的conn的boxio如何转换std::io，给 hyper.conn 使用 |
写法没问题。不过，这里没法统一起来，tls的conn需要单独处理。我添加了review comment |
baerwang
force-pushed
the
listener-tls
branch
5 times, most recently
from
18ce9d7 to
de53665
Compare
baerwang
force-pushed
the
listener-tls
branch
from
de53665 to
c21c870
Compare
|
@baerwang please check failed ci, I will close this pr. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29