-
Notifications
You must be signed in to change notification settings - Fork 98
GSOC : Add JSON serialization support for Python Dubbo #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @cnzakii, This is an exemplary pull request to demonstrate JSON serialization support in the Python Dubbo framework. PurposeThe goal of this PR is to add JSON serialization capabilities using Pydantic, by building a modular structure around Highlights
ExampleClient: self.unary = client.unary(
method_name="unary",
codec_type="json",
request_model=UserListResponse,
response_model=UserRequest
) Server: method_handler = RpcMethodHandler.unary(
UserServiceHandler().list_users,
method_name="unary",
codec_type="json",
request_model=UserRequest,
response_model=UserListResponse
) Notes
Thanks for reviewing this! Let me know your thoughts. |
@aditya0yadav |
@cnzakii |
Code Review Report and Suggestions
Due to the limited amount of code submitted, the review is brief but focused. I hope these suggestions are helpful to your development process. |
@cnzakii Thanks for the suggestion. |
What is the purpose of the change
ISSUE: #issue_number
Brief changelog
Verifying this change
Checklist