Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zookeeper auth supports #132

Merged
merged 8 commits into from
Oct 21, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add zkRoot supports
  • Loading branch information
xushaodong committed Aug 27, 2019
commit 46a6006930b219f5d92831b4c5f58aae7dd7fb4e
1 change: 1 addition & 0 deletions packages/dubbo/src/dubbo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export default class Dubbo<TService = Object>
register = Zk({
url: this._props.register as string,
zkAuthInfo: zkAuthInfo,
zkRoot: this._props.zkRoot as string,
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url为string的注册中心地址,默认是zk的注册中心,这个只作为兼容方案,后续希望收入到Zk函数,保证更好的扩展性
所以这个地方 不需要加入zkRoot和zkAuthInfo属性的设置


Expand Down
1 change: 1 addition & 0 deletions packages/dubbo/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export interface IDubboProps {
application: {name: string};
register: ((props: IDubboRegistryProps) => Registry) | string;
zkAuthInfo?: IZKAuthInfo;
zkRoot?: string;
//当前要注册到dubbo容器的服务对象
service: Object;
isSupportedDubbox?: boolean;
Expand Down