Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/support new client of prometheus #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qyi71
Copy link

@qyi71 qyi71 commented Jun 27, 2024

#35

@qyi71
Copy link
Author

qyi71 commented Jun 27, 2024

apache/dubbo#14345

@qyi71
Copy link
Author

qyi71 commented Jun 27, 2024

@AlbumenJ 大佬 我理解这个pr 和apache/dubbo#14345 这个pr要有一个先合并成功才可以吧。要不然现在这两个pr互相依赖了

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 1, 2024

This is a breaking change?

@qyi71
Copy link
Author

qyi71 commented Jul 1, 2024

This is a breaking change?

新版prometheus 客户端包路径变了

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 2, 2024

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

@qyi71
Copy link
Author

qyi71 commented Jul 2, 2024

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

Users should replace dependencies instead of upgrade them ,I don't think it will affect the work of other metrics. of course, this requires your evaluation
new dependencies (prometheus-metrics-exporter-pushgateway、prometheus-metrics-core、micrometer-registry-prometheus)

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 3, 2024

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

Users should replace dependencies instead of upgrade them ,I don't think it will affect the work of other metrics. of course, this requires your evaluation new dependencies (prometheus-metrics-exporter-pushgateway、prometheus-metrics-core、micrometer-registry-prometheus)

e.g. Dubbo depends on the new version and Spring boot actuator depends on the old version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants