introduce ConfigPostProcessor extension #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #943 +/- ##
===========================================
+ Coverage 59.92% 60.16% +0.23%
===========================================
Files 260 261 +1
Lines 12840 12895 +55
===========================================
+ Hits 7695 7758 +63
+ Misses 4186 4177 -9
- Partials 959 960 +1
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Dec 18, 2020
cityiron
approved these changes
Dec 19, 2020
watermelo
reviewed
Dec 20, 2020
watermelo
approved these changes
Dec 21, 2020
|
@watermelo in order to give more flexibility to the implementation. I introduce an empty interface for the parameter instead of a parameter's type, since people may need to look into other infos like interface or others. |
|
pls. hold on, I am still working on a better idea. |
AlexStocks
approved these changes
Dec 21, 2020
|
@AlexStocks @watermelo @cityiron would you mind to review the new solution again? |
hxmhlt
approved these changes
Dec 22, 2020
fangyincheng
approved these changes
Dec 22, 2020
georgehao
approved these changes
Dec 22, 2020
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
introduce ConfigPostProcessor extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
introduce ConfigPostProcessor extension so that user can customize configs for both ServiceConfig and ReferenceConfig further during deployment time.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: