Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#901 Optimize the memory usage. #902

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Conversation

cvictory
Copy link
Contributor

@cvictory cvictory commented Dec 2, 2020

What this PR does:

Optimize some memory usage issue , please refer to #901
In this way, we can remove some lock for it is cloned in MergeURL

Which issue(s) this PR fixes:

Fixes #901

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #902 (0ff136d) into develop (fb86fc9) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #902      +/-   ##
===========================================
- Coverage    59.88%   59.86%   -0.02%     
===========================================
  Files          260      260              
  Lines        12849    12854       +5     
===========================================
+ Hits          7694     7695       +1     
- Misses        4195     4198       +3     
- Partials       960      961       +1     
Impacted Files Coverage Δ
common/url.go 57.59% <75.00%> (+1.00%) ⬆️
remoting/kubernetes/listener.go 50.52% <0.00%> (-3.16%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 75.90% <0.00%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb86fc9...0ff136d. Read the comment docs.

@cvictory cvictory merged commit 85eadf4 into apache:develop Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants