Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr:Change verify to Makefile #831

Merged
merged 12 commits into from
Nov 3, 2020
Merged

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Nov 3, 2020

What this PR does:

  • Add Makefile for verify.
  • Github Action use Makefile.
  • Remove all before scripts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx changed the title Feature/change ci method Ftr:Change verify to Makefile Nov 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #831 into develop will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #831      +/-   ##
===========================================
- Coverage    60.17%   60.04%   -0.13%     
===========================================
  Files          260      260              
  Lines        12770    12770              
===========================================
- Hits          7684     7668      -16     
- Misses        4126     4142      +16     
  Partials       960      960              
Impacted Files Coverage Δ
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-10.17%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 46.51% <0.00%> (-4.66%) ⬇️
remoting/getty/pool.go 64.31% <0.00%> (-4.41%) ⬇️
config_center/nacos/client.go 67.36% <0.00%> (+2.10%) ⬆️
filter/filter_impl/hystrix_filter.go 70.19% <0.00%> (+2.88%) ⬆️
config_center/nacos/facade.go 89.65% <0.00%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4618a47...b6110c5. Read the comment docs.

@zouyx zouyx added the enhancement New feature or request label Nov 3, 2020
@zouyx zouyx modified the milestones: v1.5.5, v1.5.4 Nov 3, 2020
@zouyx zouyx assigned zouyx and AlexStocks and unassigned zouyx Nov 3, 2020
@cityiron
Copy link
Contributor

cityiron commented Nov 3, 2020

LGTM

@watermelo watermelo self-requested a review November 3, 2020 10:34
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zouyx zouyx merged commit 3045ae3 into apache:develop Nov 3, 2020
@zouyx zouyx deleted the feature/changeCIMethod branch November 3, 2020 16:45
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants