Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: zk lost event #692

Merged
merged 9 commits into from
Aug 6, 2020
Merged

Fix: zk lost event #692

merged 9 commits into from
Aug 6, 2020

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented Aug 5, 2020

What this PR does:
try to fix #660

fangyincheng and others added 5 commits July 26, 2020 23:38
Mod: 用词错误,忝列的意思是有愧于排列其中,应该是添加或者添列。
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #692 into master will decrease coverage by 0.02%.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   63.88%   63.85%   -0.03%     
==========================================
  Files         236      236              
  Lines       12313    12332      +19     
==========================================
+ Hits         7866     7875       +9     
- Misses       3680     3690      +10     
  Partials      767      767              
Impacted Files Coverage Δ
remoting/zookeeper/listener.go 47.19% <38.46%> (-0.79%) ⬇️
config/registry_config.go 79.31% <100.00%> (+0.36%) ⬆️
registry/zookeeper/registry.go 56.29% <100.00%> (+0.58%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.02% <0.00%> (-2.20%) ⬇️
protocol/dubbo/client.go 67.87% <0.00%> (-1.22%) ⬇️
remoting/kubernetes/listener.go 52.83% <0.00%> (ø)
remoting/kubernetes/watch.go 80.73% <0.00%> (+1.83%) ⬆️
remoting/kubernetes/client.go 78.75% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcc4df...7a88bab. Read the comment docs.

@wenxuwan wenxuwan changed the base branch from master to develop August 5, 2020 06:12
@zouyx zouyx added this to the 1.5.1 milestone Aug 5, 2020
Copy link

@gaoxinge gaoxinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit c4fbd60 into apache:develop Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data in cache is not synchronized after the provider updates in zk
7 participants