Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not inovke nacos destroy when graceful shutdown #668

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

lzp0412
Copy link
Contributor

@lzp0412 lzp0412 commented Jul 21, 2020

fix not inovke nacos destroy when graceful shutdown

registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
registry/nacos/registry.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gaoxinge gaoxinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit a04db94 into apache:1.4 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants