-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Feature/application and service level router #662
Ftr: Feature/application and service level router #662
Conversation
cc3554d
to
a41c36e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #662 +/- ##
===========================================
+ Coverage 63.80% 63.81% +0.01%
===========================================
Files 236 236
Lines 12313 12329 +16
===========================================
+ Hits 7856 7868 +12
Misses 3690 3690
- Partials 767 771 +4
Continue to review full report at Codecov.
|
b3b28d5
to
87ae81b
Compare
87ae81b
to
b33167b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about those problems ? Do you need to change ?
…r service level router
d38421d
to
95e863e
Compare
b3811fe
to
01910a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
Fixes #596
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
After this change, the local router configuration file needs to follow below pattern to support multiple routing rules in local file configuration:
the scope defines the rule's applicable range, 'application' | 'service'
the key defines the rule's applicable application name(for application scope) or the service key(for service scope, [{group}/]{service}[:{version}])