Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: experimentally distributed transaction based on seata-golang #647

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

dk-lockdown
Copy link

@dk-lockdown dk-lockdown commented Jul 6, 2020

What this PR does:
support distributed transaction, by experimentally seata-golang

Special notes for your reviewer:
this pr just added a filter, to receive xid from attachments

@AlexStocks AlexStocks changed the title support distributed transaction, by experimentally seata-golang Ftr: experimentally distributed transaction based on seata-golang Jul 6, 2020
@AlexStocks
Copy link
Contributor

@dk-lockdown pls check the travis failure.

filter/filter_impl/seata_filter.go Outdated Show resolved Hide resolved
filter/filter_impl/seata_filter.go Outdated Show resolved Hide resolved
filter/filter_impl/seata_filter.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks requested review from hxmhlt and flycash July 6, 2020 09:57
Copy link
Contributor

@Patrick0308 Patrick0308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, can be used filter with grpc or rest when another server which is not a dubbo server invoke our service.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a sample for this pr?

You can commit to the resposity as below

https://github.com/dubbogo/dubbo-samples

filter/filter_impl/seata_filter.go Outdated Show resolved Hide resolved
@dk-lockdown
Copy link
Author

dk-lockdown commented Jul 7, 2020

Can you provide a sample for this pr?

You can commit to the resposity as below

https://github.com/dubbogo/dubbo-samples

samples 我写了准备提交到一个地方,但是我看了看,如果提交到 https://github.com/dubbogo/dubbo-samples ,ci 会过不了,因为这个还要和 tc server 端配合使用,并且还需要和数据库交互

@dk-lockdown
Copy link
Author

I have a question, can be used filter with grpc or rest when another server which is not a dubbo server invoke our service.

should work

@zouyx
Copy link
Member

zouyx commented Jul 7, 2020

Can you provide a sample for this pr?
You can commit to the resposity as below
https://github.com/dubbogo/dubbo-samples

samples 我写了准备提交到一个地方,但是我看了看,如果提交到 https://github.com/dubbogo/dubbo-samples ,ci 会过不了,因为这个还要和 tc server 端配合使用,并且还需要和数据库交互

It's ok,you can ignore travis CI in this project.But you must promise your sample must work. Don'f forget write READEME.md

@dk-lockdown
Copy link
Author

Can you provide a sample for this pr?
You can commit to the resposity as below
https://github.com/dubbogo/dubbo-samples

samples 我写了准备提交到一个地方,但是我看了看,如果提交到 https://github.com/dubbogo/dubbo-samples ,ci 会过不了,因为这个还要和 tc server 端配合使用,并且还需要和数据库交互

It's ok,you can ignore travis CI in this project.But you must promise your sample must work. Don'f forget write a READEME.md

好的,写了 readme.md 的

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no question.Wait for our next version please.

@zouyx zouyx added the enhancement New feature or request label Jul 17, 2020
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit dc49015 into apache:develop Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants