-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: experimentally distributed transaction based on seata-golang #647
Conversation
@dk-lockdown pls check the travis failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, can be used filter with grpc or rest when another server which is not a dubbo server invoke our service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a sample for this pr?
You can commit to the resposity as below
samples 我写了准备提交到一个地方,但是我看了看,如果提交到 https://github.com/dubbogo/dubbo-samples ,ci 会过不了,因为这个还要和 tc server 端配合使用,并且还需要和数据库交互 |
should work |
It's ok,you can ignore travis CI in this project.But you must promise your sample must work. Don'f forget write READEME.md |
好的,写了 readme.md 的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no question.Wait for our next version please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
support distributed transaction, by experimentally seata-golang
Special notes for your reviewer:
this pr just added a filter, to receive xid from attachments