Ftr: Application-level Registry Model #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop 2 feature/dubbo-2.7.5
…n-2.7.5 # Conflicts: # common/observer/event_listener.go # registry/event.go # registry/service_discovery.go
AlexStocks
reviewed
Jul 4, 2020
fangyincheng
reviewed
Jul 5, 2020
AlexStocks
reviewed
Jul 10, 2020
AlexStocks
reviewed
Jul 10, 2020
AlexStocks
reviewed
Jul 10, 2020
flycash
force-pushed
the
2.7.5-bk
branch
5 times, most recently
from
f59430b
to
e5afb63
Compare
AlexStocks
approved these changes
Jul 10, 2020
pantianying
approved these changes
Jul 11, 2020
zouyx
reviewed
Jul 11, 2020
| type BaseListener struct { | ||
| Listenable | ||
| ListenersCache map[reflect.Type][]EventListener | ||
| Mutex sync.RWMutex |
| ) | ||
|
|
||
| const ( | ||
| defaultGroup = config_center.DEFAULT_GROUP | ||
| defaultGroup = "mapping" |
There was a problem hiding this comment.
Once you change this variable , will it cause compatibility issues?
registry/servicediscovery/synthesizer/subscribed_urls_synthesizer_factory.go
Show resolved
Hide resolved
| ) | ||
|
|
||
| // tryInitMetadataService will try to initialize metadata service | ||
| // TODO (move to somewhere) |
hxmhlt
reviewed
Jul 12, 2020
|
|
||
| const ( | ||
| ETCDV3_KEY = "etcdv3" | ||
| ) |
There was a problem hiding this comment.
Remove the constant into etcd 's directory.
| @@ -155,6 +163,14 @@ const ( | |||
| NACOS_USERNAME = "username" | |||
| ) | |||
|
|
|||
| const ( | |||
| ZOOKEEPER_KEY = "zookeeper" | |||
| ) | |||
There was a problem hiding this comment.
Remove the constant into zookeeper 's directory.
| @@ -155,6 +163,14 @@ const ( | |||
| NACOS_USERNAME = "username" | |||
| ) | |||
There was a problem hiding this comment.
Remove the constant into nacos's directory.
| @@ -64,7 +83,7 @@ func (c *BaseConfig) startConfigCenter() error { | |||
| if c.prepareEnvironment() != nil { | |||
| return perrors.WithMessagef(err, "start config center error!") | |||
| } | |||
| //c.fresh() | |||
| // c.fresh() | |||
| return err | |||
fangyincheng
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Milestone 1.5.0