Imp: Zk client #601
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,14 +18,17 @@ | |
| package zookeeper | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| import ( | ||
| "github.com/dubbogo/go-zookeeper/zk" | ||
| "github.com/stretchr/testify/require" | ||
|
There was a problem hiding this comment. I think u can rollback the testify/require to testify/assert package. There was a problem hiding this comment. an examplefunc TestSomething(t *testing.T) {
var err error
err = perrors.Errorf("something1")
assert.NoError(t, err)
err = perrors.Errorf("something2")
assert.NoError(t, err)
}
why I prefer
|
||
| ) | ||
|
|
||
| import ( | ||
| "github.com/apache/dubbo-go/common/logger" | ||
| ) | ||
|
|
||
| func verifyEventStateOrder(t *testing.T, c <-chan zk.Event, expectedStates []zk.State, source string) { | ||
|
|
@@ -35,7 +38,7 @@ func verifyEventStateOrder(t *testing.T, c <-chan zk.Event, expectedStates []zk. | |
| if !ok { | ||
| t.Fatalf("unexpected channel close for %s", source) | ||
| } | ||
| logger.Debug(event) | ||
| if event.Type != zk.EventSession { | ||
| continue | ||
| } | ||
|
|
@@ -77,7 +80,7 @@ func verifyEventStateOrder(t *testing.T, c <-chan zk.Event, expectedStates []zk. | |
|
|
||
| func Test_newMockZookeeperClient(t *testing.T) { | ||
| ts, z, event, err := NewMockZookeeperClient("test", 15*time.Second) | ||
| require.NoError(t, err) | ||
| defer ts.Stop() | ||
| states := []zk.State{zk.StateConnecting, zk.StateConnected, zk.StateHasSession} | ||
| verifyEventStateOrder(t, event, states, "event channel") | ||
|
|
@@ -87,49 +90,53 @@ func Test_newMockZookeeperClient(t *testing.T) { | |
| } | ||
|
|
||
| func TestCreate(t *testing.T) { | ||
| ts, z, event, err := NewMockZookeeperClient("test", 15*time.Second) | ||
| require.NoError(t, err) | ||
| defer ts.Stop() | ||
| err = z.Create("test1/test2/test3/test4") | ||
| require.NoError(t, err) | ||
|
|
||
| states := []zk.State{zk.StateConnecting, zk.StateConnected, zk.StateHasSession} | ||
| verifyEventStateOrder(t, event, states, "event channel") | ||
| } | ||
|
|
||
| func TestCreateDelete(t *testing.T) { | ||
| ts, z, event, err := NewMockZookeeperClient("test", 15*time.Second) | ||
| require.NoError(t, err) | ||
| defer ts.Stop() | ||
|
|
||
| states := []zk.State{zk.StateConnecting, zk.StateConnected, zk.StateHasSession} | ||
| verifyEventStateOrder(t, event, states, "event channel") | ||
| err = z.Create("/test1/test2/test3/test4") | ||
| require.NoError(t, err) | ||
| err = z.Delete("/test1/test2/test3/test4") | ||
| require.NoError(t, err) | ||
| // verifyEventOrder(t, event, []zk.EventType{zk.EventNodeCreated}, "event channel") | ||
| } | ||
|
|
||
| func TestRegisterTemp(t *testing.T) { | ||
| ts, z, event, err := NewMockZookeeperClient("test", 15*time.Second) | ||
| require.NoError(t, err) | ||
| defer ts.Stop() | ||
| err = z.Create("/test1/test2/test3") | ||
| require.NoError(t, err) | ||
|
|
||
| tmpath, err := z.RegisterTemp("/test1/test2/test3", "test4") | ||
| require.NoError(t, err) | ||
| require.Equal(t, "/test1/test2/test3/test4", tmpath) | ||
| states := []zk.State{zk.StateConnecting, zk.StateConnected, zk.StateHasSession} | ||
| verifyEventStateOrder(t, event, states, "event channel") | ||
| } | ||
|
|
||
| func TestRegisterTempSeq(t *testing.T) { | ||
| ts, z, event, err := NewMockZookeeperClient("test", 15*time.Second) | ||
| require.NoError(t, err) | ||
| defer ts.Stop() | ||
| err = z.Create("/test1/test2/test3") | ||
| require.NoError(t, err) | ||
| tmpath, err := z.RegisterTempSeq("/test1/test2/test3", []byte("test")) | ||
| require.NoError(t, err) | ||
| require.Equal(t, "/test1/test2/test3/0000000000", tmpath) | ||
| states := []zk.State{zk.StateConnecting, zk.StateConnected, zk.StateHasSession} | ||
| verifyEventStateOrder(t, event, states, "event channel") | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe u can add some comments for this struct or just using "nolint" instead.