Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage of nacos config center and configuration parser #587

Merged

Conversation

Patrick0308
Copy link
Contributor

Improve code coverage of nacos config center and configuration parser

relates #518

@codecov-commenter
Copy link

Codecov Report

Merging #587 into develop will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #587      +/-   ##
===========================================
+ Coverage    66.80%   67.18%   +0.37%     
===========================================
  Files          185      188       +3     
  Lines         9749     9849     +100     
===========================================
+ Hits          6513     6617     +104     
+ Misses        2600     2581      -19     
- Partials       636      651      +15     
Impacted Files Coverage Δ
cluster/cluster_impl/base_cluster_invoker.go 62.31% <0.00%> (-10.15%) ⬇️
protocol/dubbo/listener.go 56.45% <0.00%> (-6.46%) ⬇️
protocol/dubbo/pool.go 75.00% <0.00%> (-6.37%) ⬇️
protocol/dubbo/client.go 64.24% <0.00%> (-4.85%) ⬇️
config_center/dynamic_configuration.go 62.50% <0.00%> (ø)
config_center/mock_dynamic_config.go 0.00% <0.00%> (ø)
config_center/configuration_listener.go 0.00% <0.00%> (ø)
registry/kubernetes/registry.go 67.30% <0.00%> (+9.61%) ⬆️
config_center/nacos/client.go 75.21% <0.00%> (+19.65%) ⬆️
config_center/nacos/factory.go 62.50% <0.00%> (+50.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106040d...baf103d. Read the comment docs.

@flycash flycash merged commit 4dac621 into apache:develop Jun 6, 2020
@Patrick0308 Patrick0308 deleted the config-center-nacos-parser-cover branch June 6, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants