Improve code coverage of zookeeper config center #549
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #549 +/- ##
===========================================
- Coverage 66.92% 66.74% -0.18%
===========================================
Files 174 184 +10
Lines 9261 9693 +432
===========================================
+ Hits 6198 6470 +272
- Misses 2455 2581 +126
- Partials 608 642 +34
Continue to review full report at Codecov.
|
| err error | ||
| ) | ||
| tc, c.client, _, err = zookeeper.NewMockZookeeperClient("test", 15*time.Second, opts...) | ||
| if err != nil { |
There was a problem hiding this comment.
zookeeper.NewMockZookeeperClient may delete?
There was a problem hiding this comment.
zookeeper.NewMockZookeeperClient be used in other place.
| } | ||
| c.wg.Add(1) | ||
| go zookeeper.HandleClientRestart(c) | ||
|
|
There was a problem hiding this comment.
Is zookeeper.HandleClientRestart(c) coveraged ?
There was a problem hiding this comment.
Yeah, it's be covered. I don't know why this coverage be smaller. In my computer, cluster/cluster_impl/base_cluster_invoker.go coverage is bigger than 80%, but here the coverage is 62.31%.
Improve code coverage of zookeeper config center
relates #518