Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: Add integrate test #534

Merged
merged 3 commits into from
May 22, 2020
Merged

Ftr: Add integrate test #534

merged 3 commits into from
May 22, 2020

Conversation

sxllwx
Copy link
Member

@sxllwx sxllwx commented May 21, 2020

What this PR does:

The previous PR #520
had some scenarios that were not considered, which led to errors in integration testing when the PR was merged into the local branch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #534 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #534      +/-   ##
===========================================
- Coverage    66.37%   66.36%   -0.02%     
===========================================
  Files          184      184              
  Lines         9723     9723              
===========================================
- Hits          6454     6453       -1     
- Misses        2627     2631       +4     
+ Partials       642      639       -3     
Impacted Files Coverage Δ
cluster/cluster_impl/base_cluster_invoker.go 62.31% <0.00%> (-10.15%) ⬇️
remoting/kubernetes/client.go 59.01% <0.00%> (+0.65%) ⬆️
remoting/kubernetes/listener.go 57.00% <0.00%> (+0.93%) ⬆️
remoting/kubernetes/watch.go 80.18% <0.00%> (+0.94%) ⬆️
protocol/dubbo/client.go 69.09% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a3fd...455eb4d. Read the comment docs.

@zouyx zouyx merged commit 2a9b5fe into apache:develop May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants