Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: trace error of getGettyRpcClient #384

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Conversation

AlexStocks
Copy link
Contributor

@AlexStocks AlexStocks commented Mar 2, 2020

What this PR does:

1 Imp: trace error of getGettyRpcClient
2 update dubbogo/getty to latest version
3 update apache/dubbo-go-hessian2 to latest version

@AlexStocks AlexStocks requested review from pantianying, flycash and fangyincheng and removed request for pantianying March 2, 2020 09:41
@codecov-io
Copy link

codecov-io commented Mar 2, 2020

Codecov Report

Merging #384 into develop will increase coverage by 0.4%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #384     +/-   ##
==========================================
+ Coverage    66.73%   67.13%   +0.4%     
==========================================
  Files          157      157             
  Lines         8242     8244      +2     
==========================================
+ Hits          5500     5535     +35     
+ Misses        2215     2187     -28     
+ Partials       527      522      -5
Impacted Files Coverage Δ
protocol/dubbo/listener.go 62.9% <0%> (+5.06%) ⬆️
protocol/dubbo/pool.go 81.27% <100%> (+4.67%) ⬆️
protocol/dubbo/client.go 67.87% <40%> (-0.88%) ⬇️
config/base_config.go 63.15% <0%> (-0.08%) ⬇️
protocol/dubbo/readwriter.go 70.73% <0%> (+2.43%) ⬆️
filter/filter_impl/hystrix_filter.go 72.03% <0%> (+3.38%) ⬆️
config/consumer_config.go 55.31% <0%> (+3.39%) ⬆️
protocol/dubbo/codec.go 77.5% <0%> (+5%) ⬆️
config/provider_config.go 58.06% <0%> (+5.28%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b109ee0...c76c856. Read the comment docs.

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks changed the title Imp: trace error of getGettyRpcClient(protocol Imp: trace error of getGettyRpcClient Mar 3, 2020
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 989c001 into apache:develop Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants