Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #358 from pantianying/addRlockForDubboInvoker #364

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

fangyincheng
Copy link
Contributor

Fix:deal the panic when invoker destroy

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #364 into 1.3 will decrease coverage by 0.75%.
The diff coverage is 67.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.3     #364      +/-   ##
==========================================
- Coverage   67.85%   67.09%   -0.76%     
==========================================
  Files         118      118              
  Lines        7102     7127      +25     
==========================================
- Hits         4819     4782      -37     
- Misses       1811     1875      +64     
+ Partials      472      470       -2
Impacted Files Coverage Δ
registry/directory/directory.go 82.8% <66.66%> (-0.88%) ⬇️
protocol/dubbo/dubbo_invoker.go 83.33% <68.42%> (-8.98%) ⬇️
protocol/dubbo/pool.go 58.65% <0%> (-14.91%) ⬇️
protocol/dubbo/listener.go 50.28% <0%> (-10.41%) ⬇️
protocol/dubbo/codec.go 70.27% <0%> (-5.41%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9ba3f...95065e5. Read the comment docs.

@fangyincheng fangyincheng merged commit 082cc62 into apache:1.3 Feb 22, 2020
@fangyincheng fangyincheng deleted the 1.3 branch March 21, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants