Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest protocol #352

Merged
merged 85 commits into from
Mar 15, 2020
Merged

Rest protocol #352

merged 85 commits into from
Mar 15, 2020

Conversation

flycash
Copy link
Member

@flycash flycash commented Feb 5, 2020

What this PR does:
Provide rest protocol implementation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support rest protocol. 

@zouyx zouyx mentioned this pull request Feb 5, 2020
@hxmhlt
Copy link
Contributor

hxmhlt commented Mar 14, 2020

@fangyincheng rest_config and other_config are may be in different places. For example, other_config is in a yml, rest_config may be in code.

Config file included in consumer_config or privider_config such as registry_config or dubbo_config, user can configure them in config center. And they will be loaded from config center by reflect when dubbogo bootstrapping.

Maybe you should support your rest_config configure in config center by yourself in different places.

Fix problem of rest protocol PR #352
config/config_loader.go Outdated Show resolved Hide resolved
protocol/rest/config/reader/rest_config_reader.go Outdated Show resolved Hide resolved
protocol/rest/config/reader/rest_config_reader_test.go Outdated Show resolved Hide resolved
protocol/rest/server/server_impl/go_restful_server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hxmhlt hxmhlt merged commit cfbd042 into develop Mar 15, 2020
@flycash flycash linked an issue Mar 19, 2020 that may be closed by this pull request
@AlexStocks AlexStocks deleted the feature/rest branch January 17, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: RESTful支持
7 participants