Optimize zk ListenServiceEvent listener #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #343 +/- ##
===========================================
+ Coverage 66.14% 66.35% +0.21%
===========================================
Files 96 123 +27
Lines 6462 7596 +1134
===========================================
+ Hits 4274 5040 +766
- Misses 1742 2067 +325
- Partials 446 489 +43
Continue to review full report at Codecov.
|
zouyx
reviewed
Jan 27, 2020
| @@ -513,7 +514,7 @@ func (z *ZookeeperClient) GetChildrenW(path string) ([]string, <-chan zk.Event, | |||
| return nil, nil, perrors.Errorf("path{%s} has none children", path) | |||
| } | |||
| if len(children) == 0 { | |||
| return nil, nil, perrors.Errorf("path{%s} has none children", path) | |||
| return nil, nil, errNilChildren | |||
There was a problem hiding this comment.
i think you should print the zkpath as before, otherwise users don't know what is going on.
| @@ -544,7 +545,7 @@ func (z *ZookeeperClient) GetChildren(path string) ([]string, error) { | |||
| return nil, perrors.Errorf("path{%s} has none children", path) | |||
| } | |||
| if len(children) == 0 { | |||
| return nil, perrors.Errorf("path{%s} has none children", path) | |||
| return nil, errNilChildren | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: