support sticky connection #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingSinger
force-pushed
the
sticky
branch
4 times, most recently
from
96cae4e
to
3314986
Compare
Codecov Report
@@ Coverage Diff @@
## develop #270 +/- ##
===========================================
- Coverage 66.63% 65.78% -0.86%
===========================================
Files 112 112
Lines 7146 7167 +21
===========================================
- Hits 4762 4715 -47
- Misses 1922 1990 +68
Partials 462 462
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Dec 4, 2019
| package cluster_impl | ||
|
|
||
| import ( | ||
| "context" |
There was a problem hiding this comment.
pls split import to 3 blocks as other files.
|
should stickyInvoker check available? |
CodingSinger
force-pushed
the
sticky
branch
2 times, most recently
from
5bb5806
to
6e23b28
Compare
yes, i have added this logic. |
CodingSinger
force-pushed
the
sticky
branch
5 times, most recently
from
565bfb2
to
fab007c
Compare
hxmhlt
reviewed
Dec 19, 2019
| var selectedInvoker protocol.Invoker | ||
| url := invokers[0].GetUrl() | ||
| sticky := url.GetParam(constant.STICKY_KEY, "false") | ||
| //Get the service method sticky config if have |
| } | ||
|
|
||
| if sticky == "true" && invoker.stickyInvoker != nil && (invoked == nil || !isInvoked(invoker.stickyInvoker, invoked)) { | ||
| if invoker.availablecheck && invoker.stickyInvoker.IsAvailable() { |
There was a problem hiding this comment.
I think sticky should changed to bool type.
hxmhlt
reviewed
Dec 19, 2019
hxmhlt
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support the sticky connection