Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: triple msgpack invocation #2613

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

DMwangnima
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 47.78%. Comparing base (c865c83) to head (07fc340).
Report is 1 commits behind head on main.

Files Patch % Lines
protocol/triple/triple_protocol/codec.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
+ Coverage   47.56%   47.78%   +0.21%     
==========================================
  Files         336      341       +5     
  Lines       24840    24998     +158     
==========================================
+ Hits        11816    11945     +129     
- Misses      11876    11899      +23     
- Partials     1148     1154       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@FinalT FinalT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DMwangnima DMwangnima merged commit 8a87c62 into apache:main Mar 10, 2024
5 checks passed
@DMwangnima DMwangnima deleted the fix/triple_msgpack_serialization branch March 10, 2024 03:18
FoghostCn pushed a commit to FoghostCn/dubbo-go that referenced this pull request Mar 27, 2024
* fix: triple msgpack invocation

* fix triple test

* add msgpackCodec unit test

* fix golang-ci lint

* fix ineffectual assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants