-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interleaved weighted round-robin and alias-method loadbalancer #2606
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
==========================================
+ Coverage 47.55% 47.73% +0.17%
==========================================
Files 336 341 +5
Lines 24839 24994 +155
==========================================
+ Hits 11813 11930 +117
- Misses 11877 11910 +33
- Partials 1149 1154 +5 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution, @NX-Official! No need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there any documentation describing the advantages of these strategies?
Can we merge this PR or there has something else to do ? |
There is an issue:
Could you add some comments to |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Add two algorithm of loadbalancer :
interleaved weighted round-robin(iwrr)
andalias method
from cloudwego/kitex.ref: cloudwego/kitex#1199
ref: cloudwego/kitex#1019