Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: init otel-grpc exporter #2579

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix: init otel-grpc exporter #2579

merged 1 commit into from
Jan 16, 2024

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jan 15, 2024

Fix the following issues.

2024-01-15 19:16:27     INFO    logger/logging.go:42    The following profiles are active: [default]
2024-01-15 19:16:27     INFO    config/root_config.go:138       [Config Center] Config center doesn't start
panic: Cannot find the trace provider with name otlp-grpc

Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2489243) 47.54% compared to head (99e8e11) 47.52%.

❗ Current head 99e8e11 differs from pull request most recent head 1e6986a. Consider uploading reports for the commit 1e6986a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   47.54%   47.52%   -0.02%     
==========================================
  Files         318      318              
  Lines       23571    23565       -6     
==========================================
- Hits        11206    11200       -6     
- Misses      11304    11305       +1     
+ Partials     1061     1060       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DMwangnima
Copy link
Contributor

Since health-check conflicts have been resolved. It is okay to add this import again? @ev1lQuark

@ev1lQuark
Copy link
Contributor

Since health-check conflicts have been resolved. It is okay to add this import again? @ev1lQuark

I think it's ok to add it.

Copy link
Contributor

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DMwangnima DMwangnima merged commit 01babaa into apache:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants