-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Remove unnecessary dependency on dubbogo/grpc-go #2573
Conversation
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
…c.go Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, pls fix the CI.
protocol/triple/triple_protocol/internal/interoperability/interop.triple_wrapper.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
- Coverage 47.82% 47.45% -0.37%
==========================================
Files 318 318
Lines 23436 23557 +121
==========================================
- Hits 11208 11180 -28
- Misses 11169 11316 +147
- Partials 1059 1061 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@shikharish You really did a good job! Are you willing to participate in our samples transformation work? We'd love it if you could get involved. |
@DMwangnima Yes, I would love to! |
@shikharish Great! Can you give me your email address since we could contact you fast. This is my email: |
@DMwangnima Here's my email: shikharish05@gmail.com |
@shikharish Welcome! As you might have already noticed, the API in the main branch differs from that in the previous versions. According to the plan we have with the 3.2.0 release, we will provide a lightweight implemented, and more front-end-friendly RPC protocol that is 100% compatible with gRPC. We will also have the programming API updated with the new protocol, which should be easier and straightforward for users to use and understand. With most of the tasks done in the main branch of apache/dubbo, it becomes the priority task to update the examples in apache/dubbo-go-samples to adapt to the new API, so it can work well as demo showcases for users and integration tests for ourselves. |
@DMwangnima has already finished the |
@chickenlj So should I just pick one part and update it to use the new API? Or as @DMwangnima said he would let me know about it? |
Oh, the hard part with this task is that we are not just updating the old samples. Some of the old samples are not well designed for demo purposes, so in my opinion, we should move all the old samples into the compatibility directory only for testing in the future. Based on this context, I think we need to rebuild the sample project from scratch, to decide what are the examples that we need to show to users. Here are some features that I think are important for users:
|
@shikharish Please see the comment I left above, I think you can start with some of the above features now. I opened a PR to relocate the old examples into the compatibility directory apache/dubbo-go-samples#666. Those examples will only work as IT cases and references for creating new ones. There are already two examples there using the new API ( |
@chickenlj Thank you. I will update soon! |
Closes #2560