Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove unnecessary dependency on dubbogo/grpc-go #2573

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Refactor: Remove unnecessary dependency on dubbogo/grpc-go #2573

merged 6 commits into from
Jan 11, 2024

Conversation

shikharish
Copy link
Contributor

Closes #2560

Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
…c.go

Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Copy link
Contributor

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, pls fix the CI.

Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shikharish shikharish requested a review from DMwangnima January 11, 2024 06:02
@codecov-commenter
Copy link

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (4f21a41) 47.82% compared to head (9562080) 47.45%.

❗ Current head 9562080 differs from pull request most recent head 1d02618. Consider uploading reports for the commit 1d02618 to get more accurate results

Files Patch % Lines
protocol/triple/triple_protocol/codec.go 0.00% 141 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   47.82%   47.45%   -0.37%     
==========================================
  Files         318      318              
  Lines       23436    23557     +121     
==========================================
- Hits        11208    11180      -28     
- Misses      11169    11316     +147     
- Partials     1059     1061       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DMwangnima DMwangnima merged commit eeab1e9 into apache:main Jan 11, 2024
5 checks passed
@DMwangnima
Copy link
Contributor

@shikharish You really did a good job! Are you willing to participate in our samples transformation work? We'd love it if you could get involved.

@shikharish
Copy link
Contributor Author

shikharish commented Jan 11, 2024

@DMwangnima Yes, I would love to!

@DMwangnima
Copy link
Contributor

@shikharish Great! Can you give me your email address since we could contact you fast. This is my email:
dmdwangyuxuan@gmail.com. And this task would be published in https://github.com/apache/dubbo-go-samples. I would let you know if this issue published successfully.

@shikharish
Copy link
Contributor Author

@DMwangnima Here's my email: shikharish05@gmail.com
Thank you!

@chickenlj
Copy link
Contributor

@shikharish Welcome!

As you might have already noticed, the API in the main branch differs from that in the previous versions. According to the plan we have with the 3.2.0 release, we will provide a lightweight implemented, and more front-end-friendly RPC protocol that is 100% compatible with gRPC. We will also have the programming API updated with the new protocol, which should be easier and straightforward for users to use and understand.

With most of the tasks done in the main branch of apache/dubbo, it becomes the priority task to update the examples in apache/dubbo-go-samples to adapt to the new API, so it can work well as demo showcases for users and integration tests for ourselves.

@chickenlj
Copy link
Contributor

@DMwangnima has already finished the helloworld and registry parts in apache/dubbo-go-samples, which can be used as a reference usage of the new API.

@shikharish
Copy link
Contributor Author

shikharish commented Jan 11, 2024

@chickenlj So should I just pick one part and update it to use the new API? Or as @DMwangnima said he would let me know about it?

@chickenlj
Copy link
Contributor

chickenlj commented Jan 11, 2024

Oh, the hard part with this task is that we are not just updating the old samples. Some of the old samples are not well designed for demo purposes, so in my opinion, we should move all the old samples into the compatibility directory only for testing in the future.

Based on this context, I think we need to rebuild the sample project from scratch, to decide what are the examples that we need to show to users.

Here are some features that I think are important for users:

  • RPC Framework
    • helloworld, basic rpc usage
    • streaming rpc
    • timeout
    • retry
    • context, extra arguments
    • filter
    • error
    • no-proto mode
  • Microservice Features
    • registry, service discovery
    • config, dubbogo.yml usage
    • metrics
    • tracing
    • healthcheck
    • logger
    • interop
      • dubbo-java
      • grpc

@chickenlj
Copy link
Contributor

chickenlj commented Jan 11, 2024

@shikharish Please see the comment I left above, I think you can start with some of the above features now.

I opened a PR to relocate the old examples into the compatibility directory apache/dubbo-go-samples#666. Those examples will only work as IT cases and references for creating new ones.

There are already two examples there using the new API (helloworld and registry) for reference in that repo😀

@shikharish
Copy link
Contributor Author

@chickenlj Thank you. I will update soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid unnecessary dependency on dubbogo/grpc-go
4 participants