Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:save old service info #2556

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Jan 3, 2024

No description provided.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4649d8a) 47.76% compared to head (d4547c1) 47.77%.

❗ Current head d4547c1 differs from pull request most recent head d025247. Consider uploading reports for the commit d025247 to get more accurate results

Files Patch % Lines
protocol/triple/server.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
+ Coverage   47.76%   47.77%   +0.01%     
==========================================
  Files         318      318              
  Lines       23399    23420      +21     
==========================================
+ Hits        11177    11190      +13     
- Misses      11163    11171       +8     
  Partials     1059     1059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chickenlj chickenlj merged commit 7341d50 into apache:main Jan 5, 2024
5 checks passed
@FinalT FinalT deleted the feat-compat-reflect branch January 7, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants