Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metadata #2534

Merged
merged 31 commits into from
Mar 4, 2024
Merged

Refactor metadata #2534

merged 31 commits into from
Mar 4, 2024

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Dec 9, 2023 •
edited
Loading

resolve #2432

Refector metadata

@chickenlj chickenlj changed the title Refect metadata Refactor metadata Dec 10, 2023
@FoghostCn FoghostCn marked this pull request as draft December 11, 2023 02:26
@FoghostCn FoghostCn force-pushed the refect-metadata branch 2 times, most recently from b34486d to 09ae67b Compare January 2, 2024 04:17
@FoghostCn FoghostCn marked this pull request as ready for review January 2, 2024 04:17
@FoghostCn
Copy link
Contributor Author

metadata service tri support move to #2540

@FinalT FinalT mentioned this pull request Jan 3, 2024
Open
DMwangnima
DMwangnima reviewed Jan 5, 2024
View reviewed changes
metadata/info/metadata_info_test.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
metadata/client.go Outdated Show resolved Hide resolved
metadata/client.go Outdated Show resolved Hide resolved
metadata/client.go Show resolved Hide resolved
DMwangnima
DMwangnima reviewed Jan 5, 2024
View reviewed changes
global/registry_config.go Outdated Show resolved Hide resolved
metadata/mapping/metadata/service_name_mapping.go Outdated Show resolved Hide resolved
metadata/mapping/metadata/service_name_mapping.go Show resolved Hide resolved
@FoghostCn FoghostCn force-pushed the refect-metadata branch 2 times, most recently from 192c83c to 8f6cf25 Compare January 8, 2024 11:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (198504b) 47.55% compared to head (2e54f26) 47.38%.

❗ Current head 2e54f26 differs from pull request most recent head e283246. Consider uploading reports for the commit e283246 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-3.3    #2534      +/-   ##
===========================================
- Coverage    47.55%   47.38%   -0.18%     
===========================================
  Files          318      324       +6     
  Lines        23627    24653    +1026     
===========================================
+ Hits         11236    11681     +445     
- Misses       11328    11880     +552     
- Partials      1063     1092      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FoghostCn FoghostCn mentioned this pull request Jan 9, 2024
Closed
DMwangnima
DMwangnima reviewed Jan 14, 2024
View reviewed changes
metadata/mapping/metadata/service_name_mapping.go Outdated Show resolved Hide resolved
metadata/report/instance/metadata_report.go Outdated Show resolved Hide resolved
metadata/report/instance/metadata_report.go Outdated Show resolved Hide resolved
metadata/report/instance/metadata_report.go Outdated Show resolved Hide resolved
DMwangnima
DMwangnima reviewed Jan 14, 2024
View reviewed changes
registry/exposed_tmp/exposed.go Show resolved Hide resolved
registry/exposed_tmp/exposed.go Outdated Show resolved Hide resolved
@FoghostCn FoghostCn force-pushed the refect-metadata branch 2 times, most recently from a9894b4 to 222442b Compare January 15, 2024 05:29
@chickenlj
Copy link
Contributor

Remember to create a new branch like release-3.2.0-alpha before merging into main. Because this is not something ready for the first release.

@chickenlj chickenlj changed the base branch from main to dev-3.3 February 4, 2024 02:44
@FoghostCn
Copy link
Contributor Author

the CI seems has some problem,plz rerun CI

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

FinalT
FinalT reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@FinalT FinalT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit d6464e4 into apache:dev-3.3 Mar 4, 2024
5 checks passed
@FoghostCn FoghostCn deleted the refect-metadata branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinalT FinalT FinalT left review comments

@DMwangnima DMwangnima Awaiting requested review from DMwangnima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FoghostCn @codecov-commenter @chickenlj @DMwangnima @FinalT