Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adapt config.load #2531

Merged
merged 8 commits into from
Dec 5, 2023
Merged

feat: Adapt config.load #2531

merged 8 commits into from
Dec 5, 2023

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Dec 2, 2023

Adapt healthCheck Service and reflection Service

DMwangnima
DMwangnima reviewed Dec 3, 2023
View reviewed changes
@FinalT FinalT requested a review from DMwangnima December 3, 2023 23:02
DMwangnima
DMwangnima reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add two readme files to /protocol/triple/health/triple_health and /protocol/triple/reflection/triple_reflection. Tell developers that pb.go and triple.go are generated by dubboXXX package and grpcXXX package.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DMwangnima DMwangnima merged commit ffb8b76 into apache:main Dec 5, 2023
@FinalT FinalT deleted the adaptation branch December 29, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMwangnima DMwangnima DMwangnima left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FinalT @DMwangnima