Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Clone from target branch #2468

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Oct 28, 2023

We are maintaining several branches at this time, e.g. release-3.0 and
main. However, cloning dubbo-go-samples for integrate testing is still from
master. This leads to CI failure on old branch, like release-3.0, when the
master branch have received some breaking changes. Therefore, the
dubbo-go-samples' branch is required to keep same as the target branch.

We are maintaining several branches at this time, e.g. release-3.0 and
main. However, cloning dubbo-go-samples for integrate testing is still from
master. This leads to CI failure on old branch, like release-3.0, when the
master branch have received some breaking changes. Therefore, the
dubbo-go-samples' branch is required to keep same as the target branch.

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #2468 (fda1ddd) into main (cccb67d) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head fda1ddd differs from pull request most recent head e89025b. Consider uploading reports for the commit e89025b to get more accurate results

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   45.17%   45.11%   -0.07%     
==========================================
  Files         269      269              
  Lines       18190    18190              
==========================================
- Hits         8217     8206      -11     
- Misses       9095     9109      +14     
+ Partials      878      875       -3     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justxuewei justxuewei merged commit 918f22a into apache:main Oct 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants