Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: metrics config #2465

Merged
merged 2 commits into from
Oct 30, 2023
Merged

refactor: metrics config #2465

merged 2 commits into from
Oct 30, 2023

Conversation

ev1lQuark
Copy link
Contributor

Resolves #2464

chickenlj
chickenlj approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

FoghostCn
FoghostCn approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 3d97d4c into apache:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoghostCn FoghostCn FoghostCn approved these changes

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MetricsConfig has too much enable fields
3 participants
@ev1lQuark @FoghostCn @chickenlj