Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]fix dubbo group issues#238 #243

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

apollo-go
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #243 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   64.59%   64.51%   -0.09%     
==========================================
  Files          95       95              
  Lines        6570     6571       +1     
==========================================
- Hits         4244     4239       -5     
- Misses       1888     1894       +6     
  Partials      438      438
Impacted Files Coverage Δ
protocol/dubbo/client.go 69.07% <100%> (+0.2%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 54.71% <0%> (-16.99%) ⬇️
config_center/zookeeper/listener.go 82.6% <0%> (-4.35%) ⬇️
remoting/zookeeper/client.go 64.45% <0%> (+0.57%) ⬆️
remoting/zookeeper/listener.go 47.93% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6221170...c29a9e1. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks
Copy link
Contributor

@apollo-go pls change the target branch to develop. thx.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng
Copy link
Contributor

@apollo-go pls change the target branch to develop. thx.

I think a bug should be merged to branch master, and create a pr to branch develop again.

@AlexStocks AlexStocks merged commit 5473e10 into apache:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants