Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server side #2421

Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat: add server side #2421

merged 1 commit into from
Sep 13, 2023

Conversation

L2ncE
Copy link
Contributor

@L2ncE L2ncE commented Sep 10, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 32 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Username string
Password string
Methods []string
MethodInfo []server.MethodInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should discuss with others about introducing new field into URL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should revisit the necessity of adding this new field and its possible affect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use URL.Attributes to deliver MethodInfo, URL.Attributes is designed for delivering objects for runtime use.

Username string
Password string
Methods []string
MethodInfo []server.MethodInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use URL.Attributes to deliver MethodInfo, URL.Attributes is designed for delivering objects for runtime use.

@chickenlj
Copy link
Contributor

I will merge this pull request first for later development convenience. We will definitely need to check the URL part change introduced in this pull request.

@chickenlj chickenlj merged commit 5d1552b into apache:feature-triple Sep 13, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants