-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server side #2421
feat: add server side #2421
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Username string | ||
Password string | ||
Methods []string | ||
MethodInfo []server.MethodInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should discuss with others about introducing new field into URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should revisit the necessity of adding this new field and its possible affect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use URL.Attributes
to deliver MethodInfo
, URL.Attributes
is designed for delivering objects for runtime use.
Username string | ||
Password string | ||
Methods []string | ||
MethodInfo []server.MethodInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use URL.Attributes
to deliver MethodInfo
, URL.Attributes
is designed for delivering objects for runtime use.
I will merge this pull request first for later development convenience. We will definitely need to check the URL part change introduced in this pull request. |
No description provided.