Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify configuration when enable metrics #2408

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

ev1lQuark
Copy link
Contributor

Resolve: #2407

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2408 (6b53b60) into main (0a02805) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #2408      +/-   ##
==========================================
- Coverage   44.43%   44.36%   -0.07%     
==========================================
  Files         303      303              
  Lines       18402    18419      +17     
==========================================
- Hits         8177     8172       -5     
- Misses       9360     9381      +21     
- Partials      865      866       +1     
Files Changed Coverage Δ
config/reference_config.go 23.68% <0.00%> (-0.37%) ⬇️
config/service_config.go 50.62% <50.00%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj merged commit 314b09d into apache:main Sep 4, 2023
6 checks passed
@ev1lQuark ev1lQuark deleted the metrics-enable branch September 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify configuration when enable metrics module
4 participants