Implement meta cache #2371
Merged
Implement meta cache #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
- Coverage 44.27% 44.09% -0.18%
==========================================
Files 304 305 +1
Lines 18528 18604 +76
==========================================
+ Hits 8203 8204 +1
- Misses 9467 9541 +74
- Partials 858 859 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
registry/servicediscovery/service_instances_changed_listener_impl.go
Outdated
Show resolved
Hide resolved
justxuewei
reviewed
Aug 9, 2023
Lvnszn
reviewed
Aug 9, 2023
| } | ||
|
|
||
| // destroy stops the cache expiration routine, clears the cache and removes the cache file. | ||
| func (cm *CacheManager) destroy() { |
Lvnszn
reviewed
Aug 9, 2023
|
@justxuewei please rerun ci |
justxuewei
reviewed
Aug 10, 2023
registry/servicediscovery/service_instances_changed_listener_impl.go
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.