Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sliding window and rt quantile metrics #2356

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

ev1lQuark
Copy link
Contributor

  • Implement sliding window and wrapper it around t-digest algorithm.
  • Implement rt p50, p90, p95, p99.
# HELP dubbo_consumer_rt_milliseconds_p50 
# TYPE dubbo_consumer_rt_milliseconds_p50 gauge
dubbo_consumer_rt_milliseconds_p50{application_name="dubbo.io",group="dubbo-go",hostname="not implemented yet",interface="org.apache.dubbogo.samples.api.Greeter",ip="192.168.48.156",method="",version="3.0.1"} 171
# HELP dubbo_consumer_rt_milliseconds_p90 
# TYPE dubbo_consumer_rt_milliseconds_p90 gauge
dubbo_consumer_rt_milliseconds_p90{application_name="dubbo.io",group="dubbo-go",hostname="not implemented yet",interface="org.apache.dubbogo.samples.api.Greeter",ip="192.168.48.156",method="",version="3.0.1"} 201.39999999999998
# HELP dubbo_consumer_rt_milliseconds_p95 
# TYPE dubbo_consumer_rt_milliseconds_p95 gauge
dubbo_consumer_rt_milliseconds_p95{application_name="dubbo.io",group="dubbo-go",hostname="not implemented yet",interface="org.apache.dubbogo.samples.api.Greeter",ip="192.168.48.156",method="",version="3.0.1"} 201.95000000000002
# HELP dubbo_consumer_rt_milliseconds_p99 
# TYPE dubbo_consumer_rt_milliseconds_p99 gauge
dubbo_consumer_rt_milliseconds_p99{application_name="dubbo.io",group="dubbo-go",hostname="not implemented yet",interface="org.apache.dubbogo.samples.api.Greeter",ip="192.168.48.156",method="",version="3.0.1"} 202

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #2356 (f7bb4e2) into main (f6fdbfd) will increase coverage by 0.09%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main    #2356      +/-   ##
==========================================
+ Coverage   44.27%   44.37%   +0.09%     
==========================================
  Files         294      297       +3     
  Lines       18019    18127     +108     
==========================================
+ Hits         7978     8043      +65     
- Misses       9194     9232      +38     
- Partials      847      852       +5     
Impacted Files Coverage Δ
metrics/util/aggregate/pane.go 60.00% <60.00%> (ø)
metrics/util/aggregate/quantile.go 76.00% <76.00%> (ø)
metrics/util/aggregate/sliding_window.go 76.92% <76.92%> (ø)
metrics/prometheus/model.go 39.22% <78.26%> (+5.68%) ⬆️
metrics/prometheus/metric_set.go 100.00% <100.00%> (ø)
metrics/prometheus/reporter.go 76.08% <100.00%> (+0.53%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 412bf7b into apache:main Jul 14, 2023
@ev1lQuark ev1lQuark deleted the time-window branch July 19, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants