Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablewrite cli show #2237

Merged
merged 1 commit into from
Mar 16, 2023
Merged

tablewrite cli show #2237

merged 1 commit into from
Mar 16, 2023

Conversation

Leospard
Copy link
Contributor

@Leospard Leospard commented Mar 3, 2023

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #2237 (9d3d48a) into 3.0 (b492dba) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.0    #2237      +/-   ##
==========================================
+ Coverage   44.19%   44.29%   +0.09%     
==========================================
  Files         283      283              
  Lines       17172    17206      +34     
==========================================
+ Hits         7590     7622      +32     
+ Misses       8784     8782       -2     
- Partials      798      802       +4     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justxuewei justxuewei merged commit 60127cc into apache:3.0 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants