Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consumers try to reconnect to the metadata service of offline providers infinitely #2166

Merged
merged 13 commits into from
Dec 25, 2022
Merged

fix: Consumers try to reconnect to the metadata service of offline providers infinitely #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4ef133
registry type support all
Nov 27, 2022
d7ab2a5
fix test
Nov 27, 2022
b89a439
set default to interface
Nov 29, 2022
5ef0936
use default protocol registry
Dec 1, 2022
b3e5677
fix unit test
Dec 1, 2022
d17d6a6
use swith to judge
Dec 3, 2022
f408f36
add registry support all test
Dec 5, 2022
fb2e656
Merge branch 'apache:3.0' into 3.0
bobtthp Dec 10, 2022
3b53955
Resolve registry name conflicts
Dec 10, 2022
4ffc0b1
fix ut err
Dec 11, 2022
5c4c2d0
fix https://github.com/apache/dubbo-go/issues/2159
Dec 21, 2022
21516be
del front
Dec 23, 2022
cb02ef3
del front
Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metadata/service/local/service_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ func (m *MetadataServiceProxy) GetMetadataInfo(revision string) (*common.Metadat
invocation.WithAttachments(map[string]interface{}{constant.AsyncKey: "false"}),
invocation.WithParameterValues([]reflect.Value{rV}))
res := m.invkr.Invoke(context.Background(), inv)
// when request finished, invoker will colse
defer m.invkr.Destroy()
if res.Error() != nil {
logger.Errorf("could not get the metadata info from remote provider: %v", res.Error())
return nil, res.Error()
Expand Down
7 changes: 1 addition & 6 deletions metadata/service/local_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,7 @@ func NewBaseMetadataServiceProxyFactory(creator MetadataServiceProxyCreator) *Ba
}

func (b *BaseMetadataServiceProxyFactory) GetProxy(ins registry.ServiceInstance) MetadataService {
key := ins.GetServiceName() + "##" + getExportedServicesRevision(ins)
if proxy, ok := b.proxies.Load(key); ok {
return proxy.(MetadataService)
}
v, _ := b.proxies.LoadOrStore(key, b.creator(ins))
return v.(MetadataService)
return b.creator(ins).(MetadataService)
}

func getExportedServicesRevision(serviceInstance registry.ServiceInstance) string {
Expand Down