Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:ENV DUBBO_IP_TO_REGISTRY doesn't work #2138

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

Code-Fight
Copy link
Contributor

What this PR does:
fix DUBBO_IP_TO_REGISTRY doesn't work
Which issue(s) this PR fixes:
Fixes #
#2096

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2138 (181b2f0) into 3.0 (d332f1b) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2138      +/-   ##
==========================================
- Coverage   44.44%   44.34%   -0.11%     
==========================================
  Files         283      283              
  Lines       17015    17016       +1     
==========================================
- Hits         7563     7545      -18     
- Misses       8658     8678      +20     
+ Partials      794      793       -1     
Impacted Files Coverage Δ
...try/servicediscovery/service_discovery_registry.go 1.26% <0.00%> (-0.01%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
cluster/loadbalance/ringhash/ring.go 84.50% <0.00%> (-2.82%) ⬇️
metrics/prometheus/reporter.go 30.25% <0.00%> (-1.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyunxing92 zhaoyunxing92 merged commit 9007a29 into apache:3.0 Nov 27, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
binbin0325 pushed a commit to binbin0325/dubbo-go that referenced this pull request Dec 10, 2022
* fix don't support DUBBO_IP_TO_REGISTRY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants