Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when the routing policy is not set, the setInvokers() method has a co process leak #2104

Merged
merged 10 commits into from
Nov 26, 2022
Merged

fix: when the routing policy is not set, the setInvokers() method has a co process leak #2104

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
915f117
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 4, 2022
1cddc87
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 9, 2022
c875dae
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 14, 2022
bb2f9eb
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 14, 2022
d31f141
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 14, 2022
2d676b0
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 15, 2022
c03a4e9
Merge pull request #1 from apache/1.5
caochengxiang Nov 16, 2022
2bdcd9b
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 16, 2022
b87b6b4
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 26, 2022
adbcda0
非路由策略下，不触发节点变更的数据变更协程消息
caochengxiang Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions cluster/router/chain/chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,15 @@ type RouterChain struct {
notify chan struct{}
// Address cache
cache atomic.Value

routerStatus atomic.Int32
}

const (
NoHasRouter = iota
caochengxiang marked this conversation as resolved.
Show resolved Hide resolved
HasRouter
)

func (c *RouterChain) GetNotifyChan() chan struct{} {
return c.notify
}
Expand Down Expand Up @@ -113,6 +120,10 @@ func (c *RouterChain) AddRouters(routers []router.PriorityRouter) {
c.mutex.Lock()
defer c.mutex.Unlock()
c.routers = newRouters
if c.routerStatus.Load() == NoHasRouter {
return
}

go func() {
c.notify <- struct{}{}
}()
Expand All @@ -124,6 +135,9 @@ func (c *RouterChain) SetInvokers(invokers []protocol.Invoker) {
c.mutex.Lock()
c.invokers = invokers
c.mutex.Unlock()
if c.routerStatus.Load() == NoHasRouter {
return
}

go func() {
c.notify <- struct{}{}
Expand Down Expand Up @@ -296,6 +310,7 @@ func NewRouterChain(url *common.URL) (*RouterChain, error) {
last: time.Now(),
notify: make(chan struct{}),
}
chain.routerStatus.Store(HasRouter)

routers := make([]router.PriorityRouter, 0, len(routerFactories))
for key, routerFactory := range routerFactories {
Expand Down