Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hessian to v1.11.3 #2087

Merged
merged 2 commits into from
Oct 31, 2022
Merged

upgrade hessian to v1.11.3 #2087

merged 2 commits into from
Oct 31, 2022

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Oct 24, 2022

What this PR does:
upgrade hessian to v1.11.3, see

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@AlexStocks
Copy link
Contributor

pls fix the above ci failure.

@AlexStocks AlexStocks changed the base branch from master to 3.0 October 26, 2022 11:05
@wongoo
Copy link
Contributor Author

wongoo commented Oct 27, 2022

ref: apache/dubbo-go-samples#461

@AlexStocks
Copy link
Contributor

ref: apache/dubbo-go-samples#461

I have merge apache/dubbo-go-samples#461 and re-run the ci job. it fails again.

@wongoo
Copy link
Contributor Author

wongoo commented Oct 29, 2022

should upgrade hessian2, ref apache/dubbo-go-hessian2#332

@wongoo wongoo changed the title upgrade hessian to v1.11.2 upgrade hessian to v1.11.3 Oct 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2087 (2eb05e2) into 3.0 (7c0dcdd) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.0    #2087      +/-   ##
==========================================
+ Coverage   44.67%   44.76%   +0.09%     
==========================================
  Files         281      281              
  Lines       16864    16864              
==========================================
+ Hits         7534     7550      +16     
+ Misses       8541     8523      -18     
- Partials      789      791       +2     
Impacted Files Coverage Δ
metrics/prometheus/reporter.go 31.79% <0.00%> (+1.53%) ⬆️
metadata/report/delegate/delegate_report.go 35.09% <0.00%> (+8.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit e591551 into apache:3.0 Oct 31, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants