Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Support getting metadata from metadataCenter #2066

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

Leospard
Copy link
Contributor

@Leospard Leospard commented Sep 30, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #2066 (0b2095e) into 3.0 (aab693f) will decrease coverage by 0.00%.
The diff coverage is 61.33%.

@@            Coverage Diff             @@
##              3.0    #2066      +/-   ##
==========================================
- Coverage   44.59%   44.59%   -0.01%     
==========================================
  Files         283      281       -2     
  Lines       17073    16836     -237     
==========================================
- Hits         7614     7508     -106     
+ Misses       8653     8540     -113     
+ Partials      806      788      -18     
Impacted Files Coverage Δ
cluster/cluster/zoneaware/cluster_interceptor.go 40.00% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
common/url.go 59.50% <0.00%> (+0.45%) ⬆️
config/config_loader.go 17.56% <0.00%> (ø)
config/consumer_config.go 22.58% <0.00%> (ø)
config/graceful_shutdown.go 3.88% <0.00%> (ø)
config/provider_config.go 41.53% <0.00%> (ø)
config/service_config.go 53.04% <0.00%> (ø)
metadata/identifier/base_metadata_identifier.go 86.48% <0.00%> (-7.64%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjphaha
Copy link
Member

cjphaha commented Sep 30, 2022

LGTM,pls updae the readme

@Leospard Leospard changed the title [WIP] CLI: Support getting metadata from metadataCenter CLI: Support getting metadata from metadataCenter Oct 22, 2022
@cjphaha cjphaha merged commit 96a30ac into apache:3.0 Oct 31, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants