Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix polaris Subscriber #2026

Merged
merged 24 commits into from
Aug 25, 2022
Merged

fix polaris Subscriber #2026

merged 24 commits into from
Aug 25, 2022

Conversation

jasondeng1997
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

justxuewei and others added 24 commits August 17, 2022 22:13
RPCInvocation::GetAttributeWithDefaultValue() has a typo which couldn't
get attributes correctly, this PR fixes that issue.

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
# Conflicts:
#	registry/zookeeper/service_discovery_test.go
# Conflicts:
#	registry/zookeeper/service_discovery_test.go
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit c134397 into apache:3.0 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants