fix PolarisServiceWatcher bug and add ZookeeperServiceDiscovery ut #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.47.0 to 1.48.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.47.0...v1.48.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@chuntaojun pls review pr |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1988 +/- ##
==========================================
+ Coverage 44.38% 44.56% +0.18%
==========================================
Files 283 283
Lines 17041 17055 +14
==========================================
+ Hits 7563 7601 +38
+ Misses 8672 8651 -21
+ Partials 806 803 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
chuntaojun
reviewed
Jul 21, 2022
registry/polaris/core.go
Outdated
| } | ||
| case <-time.After(20 * time.Second): |
There was a problem hiding this comment.
我理解阻塞在这个 select 应该没问题吧？
There was a problem hiding this comment.
阻塞20秒以后再执行,所以先执行上面的,上面的如果20秒还没有执行完,重新执行说明上面的bug,当然是否可以用户自定义，另外20秒是否过长，这个在dubbo yaml配置文件里面可以用户自定义配置
There was a problem hiding this comment.
感觉完全没有必要在在外层加一个for
大佬要不一起来DingTalk：44817370 一起聊下？
jasondeng1997
changed the title
jasondeng1997
changed the title
chuntaojun
approved these changes
Jul 23, 2022
chuntaojun
reviewed
Jul 23, 2022
registry/polaris/core.go
Outdated
| } | ||
| case <-time.After(1 * time.Second): |
chuntaojun
approved these changes
Jul 25, 2022
AlexStocks
approved these changes
Jul 25, 2022
6 tasks
justxuewei
approved these changes
Aug 2, 2022
binbin0325
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumerAPI.Subscribe 只需要执行一次，如果 Subscribe，可能是 SDK 内返回了类似 Busy 类的错误，因此需要先保证 ConsumerAPI.Subscribe 一定成功，成功之后，会返回一个用于订阅的 chan，这个chan需要走 for range or for select 的语句不断消费 chan 里面的实例变化事件，如果 chan 被 sdk 内部逻辑 close 的话，那么就又会走到外层的循环进行再次发起订阅动作，如果内部for发生错误，跳出当前for，继续执行监听事件