-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imp: remove useless time format #1955
Conversation
Hi Yepeng, thanks for your contribution, I wonder how much the performance can be improved if the |
I tested it roughly. When the QPS was high, there was about a ten or so milliseconds' improvement, but when the QPS was low, there didn't seem to be much optimization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%s print time, eventually the String() function is called as well。 If must print the time, you can make a special note。
this should not matter in debug print log mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果只是打印当前时间的话是不是用log的时间就可以了
这个需要看log中的时间与所想要打印的时间会有多大的差距,这个本来就是debug用的,我觉得现在这样处理就可以,不用太纠结这个 |
What this PR does:
Whether this log is output or not, the date will be formatted and cost a lot time, now it will be output without formatting as
2022-07-06 19:37:39.4692053 +0800 CST m=+0.775520901
Which issue(s) this PR fixes:
Fixes #1954
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed