Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: xds enhancement #1853

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

  1. Triple header 增加环境标:environment: xxx
  2. 删除掉注册在 istiod 的接口元数据中“group”和 “version”,这两个字段在xds 场景获取接口映射时无意义。

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #1853 (dde8baa) into 3.0 (ae8893a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.0    #1853      +/-   ##
==========================================
- Coverage   46.83%   46.78%   -0.05%     
==========================================
  Files         295      295              
  Lines       17172    17173       +1     
==========================================
- Hits         8042     8035       -7     
- Misses       8275     8285      +10     
+ Partials      855      853       -2     
Impacted Files Coverage Δ
common/proxy/proxy_factory/default.go 21.53% <100.00%> (+1.22%) ⬆️
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (-13.34%) ⬇️
remoting/xds/client.go 56.00% <0.00%> (-0.89%) ⬇️
metrics/prometheus/reporter.go 28.57% <0.00%> (+1.71%) ⬆️
registry/nacos/listener.go 80.86% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8893a...dde8baa. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin merged commit 84a131c into apache:3.0 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants