Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: decode net stream bytes as getty rule #1833

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Apr 15, 2022

What this PR does:
fix decode net stream bytes as getty rule in 1.5
Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@Lvnszn Lvnszn force-pushed the 1.5 branch 6 times, most recently from b27bc76 to 8bfac25 Compare April 15, 2022 16:14
@Lvnszn Lvnszn force-pushed the 1.5 branch 2 times, most recently from 950410e to 9ad16c3 Compare April 16, 2022 08:00
@binbin0325
Copy link
Member

CI 问题在看一下?

@AlexStocks
Copy link
Contributor

CI 问题在看一下?

binbin,这个可以先merge了。再来一个新的pr解决问题

@AlexStocks AlexStocks merged commit 6266471 into apache:1.5 Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants