-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adasvc): fix getting attachment issues for triple #1811
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #1811 +/- ##
==========================================
+ Coverage 47.62% 47.69% +0.06%
==========================================
Files 262 262
Lines 15115 15103 -12
==========================================
+ Hits 7199 7203 +4
+ Misses 7132 7115 -17
- Partials 784 785 +1
Continue to review full report at Codecov.
|
2578157
to
8ead2da
Compare
} else if strArr, strArrOK := remainingIface.([]string); strArrOK && len(strArr) > 0 { | ||
remainingStr = strArr[0] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分重复的代码需不需要包装成一个方法
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方我权衡过,主要 attachment 格式没有显式规定(比如数组里是否只能有一个元素之类的),所以我考虑是说先单独写。
What this PR does:
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed