Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adasvc): fix getting attachment issues for triple #1811

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Apr 5, 2022

What this PR does:

  • fix getting attachment issue for triple

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #1811 (2578157) into 3.0 (e00cf8d) will increase coverage by 0.06%.
The diff coverage is 66.66%.

❗ Current head 2578157 differs from pull request most recent head 8ead2da. Consider uploading reports for the commit 8ead2da to get more accurate results

@@            Coverage Diff             @@
##              3.0    #1811      +/-   ##
==========================================
+ Coverage   47.62%   47.69%   +0.06%     
==========================================
  Files         262      262              
  Lines       15115    15103      -12     
==========================================
+ Hits         7199     7203       +4     
+ Misses       7132     7115      -17     
- Partials      784      785       +1     
Impacted Files Coverage Δ
protocol/invocation/rpcinvocation.go 16.54% <66.66%> (+2.57%) ⬆️
registry/nacos/listener.go 78.26% <0.00%> (-2.61%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️
remoting/nacos/builder.go 76.66% <0.00%> (+2.75%) ⬆️
metadata/report/delegate/delegate_report.go 34.43% <0.00%> (+7.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00cf8d...8ead2da. Read the comment docs.

@justxuewei justxuewei changed the title fix: fix getting attachment for triple issue fix(adasvc): fix getting attachment issue for triple Apr 6, 2022
@justxuewei justxuewei changed the title fix(adasvc): fix getting attachment issue for triple fix(adasvc): fix getting attachment issues for triple Apr 6, 2022
} else if strArr, strArrOK := remainingIface.([]string); strArrOK && len(strArr) > 0 {
remainingStr = strArr[0]
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分重复的代码需不需要包装成一个方法

Copy link
Member Author

@justxuewei justxuewei Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方我权衡过,主要 attachment 格式没有显式规定(比如数组里是否只能有一个元素之类的),所以我考虑是说先单独写。

@justxuewei justxuewei merged commit c7fb54a into apache:3.0 Apr 6, 2022
@zhaoyunxing92 zhaoyunxing92 added this to the 3.0.1 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants