Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RootConfig and getty-session-param #1802

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix RootConfig and getty-session-param #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/root_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ func (rc *RootConfig) Init() error {
if err := rc.Shutdown.Init(); err != nil {
return err
}
SetRootConfig(*rc)
// todo if we can remove this from Init in the future?
rc.Start()
return nil
Expand Down
4 changes: 2 additions & 2 deletions remoting/getty/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ type (
QueueNumber int `default:"0" yaml:"queue-number" json:"queue-number,omitempty"`

// session tcp parameters
GettySessionParam GettySessionParam `required:"true" yaml:",inline" json:",inline"`
GettySessionParam GettySessionParam `required:"true" yaml:"getty-session-param" json:"getty-session-param,omitempty"`
}

// ClientConfig holds supported types by the multi config package
Expand Down Expand Up @@ -104,7 +104,7 @@ type (
QueueNumber int `default:"0" yaml:"queue-number" json:"queue-number,omitempty"`

// session tcp parameters
GettySessionParam GettySessionParam `required:"true" yaml:",inline" json:",inline"`
GettySessionParam GettySessionParam `required:"true" yaml:"getty-session-param" json:"getty-session-param,omitempty"`
}
)

Expand Down