Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support java method param java.lang #1783

Merged

Conversation

binbin0325
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:
Fixes #1782

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • [] Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #1783 (29648ed) into 3.0 (dfe4424) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1783      +/-   ##
==========================================
+ Coverage   47.61%   47.74%   +0.12%     
==========================================
  Files         262      262              
  Lines       15098    15114      +16     
==========================================
+ Hits         7189     7216      +27     
+ Misses       7123     7110      -13     
- Partials      786      788       +2     
Impacted Files Coverage Δ
protocol/dubbo/impl/hessian.go 32.88% <0.00%> (-1.50%) ⬇️
metrics/prometheus/reporter.go 28.57% <0.00%> (+1.71%) ⬆️
metadata/report/delegate/delegate_report.go 42.38% <0.00%> (+15.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe4424...29648ed. Read the comment docs.

@binbin0325 binbin0325 force-pushed the 3.0_hessian_support_java_lang branch from c0e8a46 to 29648ed Compare March 14, 2022 01:22
@LaurenceLiZhixin LaurenceLiZhixin merged commit b6ee982 into apache:3.0 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants